RFR: 8165687: Fix license and copyright headers in jd9 under hotspot/test

David Holmes david.holmes at oracle.com
Wed Oct 5 21:45:09 UTC 2016


Hi Stanislav,

On 6/10/2016 2:41 AM, Stanislav Smirnov wrote:
> Hi Iris,
>
> thanks for a review.
> Btw, I will also need a sponsor to push it.

Reviewed! And I will sponsor for you. I will push this to jdk9/hs to 
avoid future potential conflicts with test changes if that is okay? Or 
do you want it to go to jdk9/dev?

Thanks,
David

> Best regards,
> Stanislav Smirnov
>
>
>
>
>
>> On 05 Oct 2016, at 19:32, Iris Clark <iris.clark at oracle.com> wrote:
>>
>> Hi.
>>
>>> Webrev: http://cr.openjdk.java.net/~stsmirno/8165687/webrev.00/
>>
>> These appear to be the expected changes.
>>
>> I find the updates to test/gc/TestHumongousReferenceObject.java interesting.  You needed to add the word "Public" to the phrase
>> "General Public License".  It looks like somewhere during development, there was an overly enthusiastic search and replace of "Public" with "".  Regardless, it looks fine now.
>>
>> Thanks,
>> Iris
>> (not a Reviewer)
>>
>> -----Original Message-----
>> From: Stanislav Smirnov
>> Sent: Wednesday, October 05, 2016 7:56 AM
>> To: hotspot-dev at openjdk.java.net
>> Subject: RFR: 8165687: Fix license and copyright headers in jd9 under hotspot/test
>>
>> Hi,
>>
>> Please review this fix for JDK-8165687 <https://bugs.openjdk.java.net/browse/JDK-8165687>.
>> Legal notices and Oracle copyrights were updated (white and blank space, commas) in tests files for uniformity to meet Oracle requirements.
>>
>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8165687 <https://bugs.openjdk.java.net/browse/JDK-8165687>
>> Webrev: http://cr.openjdk.java.net/~stsmirno/8165687/webrev.00/ <http://cr.openjdk.java.net/~stsmirno/8165687/webrev.00/>
>>
>> Best regards,
>> Stanislav Smirnov
>


More information about the hotspot-dev mailing list