[PATCH] Invalid critical JNI function lookup (Windows x86)

Ioannis Tsakpinis iotsakp at gmail.com
Mon Oct 10 01:24:25 UTC 2016


Hi David,

On Mon, Oct 10, 2016 at 4:08 AM, David Holmes <david.holmes at oracle.com> wrote:
> Hi Ioannis,
>
> I have filed:
>
> https://bugs.openjdk.java.net/browse/JDK-8167408
>
> for this.

Thanks!

> If you haven't already, please see:
>
> http://openjdk.java.net/contribute/
>
> on how to contribute. While small simple patches can be accepted from
> anyone, more complex patches require you to sign the OCA.

Yes, I'm aware of the OCA requirement and plan to have it signed soon.
This is a simple patch (and my first contribution to OpenJDK), so I
decided to go ahead and submit it as a participant.

> BTW I don't see anything Windows x86 specific here, as this is shared code.

The OS-specific bit comes in lookup_critical_style, which passes args_size
to os::print_jni_name_prefix_on and os::print_jni_name_suffix_on. Afaict,
these don't do anything except on Windows x86.

Thanks,
Ioannis


More information about the hotspot-dev mailing list