[8u] RFR for JDK-8134389: Crash in HotSpot with jvm.dll+0x42b48 ciObjectFactory::create_new_metadata

[Vladimir Kozlov]

In ciMethod.hpp you duplicated comment line:

+   // Given a certain calling environment, find the monomorphic target
     // Given a certain calling environment, find the monomorphic target

Otherwise looks good.

Thanks,
Vladimir K

On 10/19/16 12:53 AM, Shafi Ahmad wrote:
> Hi All,
>
> Please review the backport of 'JDK-8134389: Crash in HotSpot with jvm.dll+0x42b48 ciObjectFactory::create_new_metadata' to jdk8u-dev.
>
> Please note that backport is not clean as I was getting build failure due to:
> Formal parameter 'ignore_return' in method GraphBuilder::method_return is added in the fix of https://bugs.openjdk.java.net/browse/JDK-8164122.
> The current code change is done on top of aforesaid bug fix and this formal parameter is referenced in this code change.
>   * if (x != NULL && !ignore_return) { *
>
> Author of this code change suggested me, we can safely remove this addition conditional expression ' && !ignore_return'.
>
> open webrev: http://cr.openjdk.java.net/~shshahma/8134389/webrev.00/
> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8134389
> jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4191b33b3629
>
> testing: Passes JPRT, jtreg on Linux [amd64] and newly added test case
>
> Regards,
> Shafi
>