Request for review (s) - 8155948: Add message for CMS deprecation for some internal builds

[Jon Masamitsu]

Kim,

Thanks for the review.

On 9/1/2016 7:36 AM, Kim Barrett wrote:
>> On Aug 31, 2016, at 2:06 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>
>> Adds the support to emit a deprecation message in some builds.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8155948
>>
>> A data structure is moved to a header file to allow
>> sharing and a stub function is added which can be
>> specialized for different builds.
>>
>> http://cr.openjdk.java.net/~jmasa/8155948/webrev.00/
> Mostly looks ok.  A style issue:
>
> ------------------------------------------------------------------------------
> src/share/vm/runtime/arguments.hpp
>    45 typedef struct {
> ...
>    50 } SpecialFlag;
>
> This is C++ code, not C. Rather than using typedef of an anonymous
> struct, we should be using a named struct, e.g.
>
>    struct SpecialFlag { ... };
>
> ------------------------------------------------------------------------------

Fixed per your suggestion.

Delta webrev
http://cr.openjdk.java.net/~jmasa/8155948/webrev_delta.00_01/

Full webrev
http://cr.openjdk.java.net/~jmasa/8155948/webrev.01/

Jon

>
> There are some other similar typedefs in arguments.cpp that aren’t touched by this change.






>