Request for review (s) - 8155948: Add message for CMS deprecation for some internal builds

[Jon Masamitsu]

On 09/08/2016 10:44 AM, Kim Barrett wrote:
>> On Sep 8, 2016, at 12:35 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>
>> Kim,
>>
>> Thanks for looking at this.  Comments below.
>>
>> On 09/07/2016 03:12 PM, Kim Barrett wrote:
>>> src/share/vm/runtime/arguments.cpp
>>> 4064 void Arguments::handle_concgc_flags() {
>>> 4065   SpecialFlag flag;
>>> 4066   const char *flag_name = "UseConcMarkSweepGC";
>>> 4067   if (log_is_enabled(Warning, gc) &&
>>> 4068       lookup_special_flag(flag_name, flag)) {
>>> 4069     handle_aliases_and_deprecation(flag_name, /* print warning */ true);
>>> 4070     log_warning(gc)("-Xconcgc/-Xnoconcgc uses UseConcMarkSweepGC");
>>> 4071   }
>>> 4072 }
>>>
>>> This non-trivial little dance is done both here and for
>>> UseAutoGCSelectPolicy.  I think handle_concgc_flags could deal with
>>> both if it took an argument of the "offending" flag.
>>>
>>> ------------------------------------------------------------------------------
>>>
>> -Xconcgc does not have a SpecialFlag associated with it currently. Do you mean
>> add one for "concgc" (even through it is not a -XX flags)?  Or do you mean that
>> "offending" flag is just a parameter that chooses between the two cases
>> -Xconcgc/-Xnoconcgc and -XX:+UseAutoGCSelectPolicy?
>>
>> Jon
> A parameter that is used to tailor the warning, e.g. a const char* that is %s’ed into the log_warning message.
>
Will do.

Thanks again.

Jon