Request for review (s) - 8155948: Add message for CMS deprecation for some internal builds

Kim Barrett kim.barrett at oracle.com
Mon Sep 12 18:13:34 UTC 2016


> On Sep 9, 2016, at 10:47 AM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> 
> Sorry for dragging this out but I needed to make 1 change.  I should
> have been using warning() and not log_warning(gc).  Diff is
> 
> diff --git a/src/share/vm/runtime/arguments.cpp b/src/share/vm/runtime/arguments.cpp
> --- a/src/share/vm/runtime/arguments.cpp
> +++ b/src/share/vm/runtime/arguments.cpp
> @@ -4065,7 +4065,7 @@
>   if (log_is_enabled(Warning, gc) &&
>       lookup_special_flag(flag_name, flag)) {
>     handle_aliases_and_deprecation(flag_name, /* print warning */ true);
> -    log_warning(gc)("%s", msg);
> +    warning("%s", msg);
>   }
> }
> 
> The difference is that warning() honors PrintWarnings.

In that case, shouldn’t the “log_is_enabled(Warning, gc)” instead be “PrintWarnings”?



More information about the hotspot-dev mailing list