Request for review (s) - 8155948: Add message for CMS deprecation for some internal builds

Kim Barrett kim.barrett at oracle.com
Mon Sep 12 21:40:16 UTC 2016


> On Sep 12, 2016, at 5:05 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> Simply deleting the log_is_enabled() call does result in the PrintWarnings being
> honored.  The latest change is
> 
> --- a/src/share/vm/runtime/arguments.cpp
> +++ b/src/share/vm/runtime/arguments.cpp
> @@ -4167,8 +4167,7 @@
>  void Arguments::handle_extra_cms_flags(const char* msg) {
>    SpecialFlag flag;
>    const char *flag_name = "UseConcMarkSweepGC";
> -  if (log_is_enabled(Warning, gc) &&
> -      lookup_special_flag(flag_name, flag)) {
> +  if (lookup_special_flag(flag_name, flag)) {
>      handle_aliases_and_deprecation(flag_name, /* print warning */ true);
>      warning("%s", msg);
>    }
> 
> Complete webrev is
> 
> http://cr.openjdk.java.net/~jmasa/8155948/webrev.03/index.html
> 
> Thanks.
> 
> Jon

Looks good.



More information about the hotspot-dev mailing list