[8u] RFR for JDK-6515172: Runtime.availableProcessors() ignores Linux taskset command
Shafi Ahmad
shafi.s.ahmad at oracle.com
Tue Sep 20 16:42:32 UTC 2016
Hi Gerald,
Thank you for reviewing it.
Regards,
Shafi
> -----Original Message-----
> From: Gerald Thornbrugh
> Sent: Tuesday, September 20, 2016 6:51 PM
> To: Shafi Ahmad
> Cc: David Holmes; Chris Plummer; hotspot-dev at openjdk.java.net; Daniel
> Daugherty; Roger Calnan
> Subject: Re: [8u] RFR for JDK-6515172: Runtime.availableProcessors() ignores
> Linux taskset command
>
> Hi Shafi,
>
> Your change looks good.
>
> Thanks for fixing this.
>
> Jerry
> > Adding jdk9 code change reviewer 'Daniel Daugherty' and 'Gerald
> Thornbrugh'.
> >
> > Regards,
> > Shafi
> >
> >> -----Original Message-----
> >> From: Shafi Ahmad
> >> Sent: Monday, September 19, 2016 10:25 AM
> >> To: David Holmes; Chris Plummer; hotspot-dev at openjdk.java.net
> >> Cc: Roger Calnan
> >> Subject: RE: [8u] RFR for JDK-6515172: Runtime.availableProcessors()
> >> ignores Linux taskset command
> >>
> >> May I get the second review for this change.
> >>
> >> Regards,
> >> Shafi
> >>
> >>> -----Original Message-----
> >>> From: David Holmes
> >>> Sent: Friday, September 16, 2016 7:16 AM
> >>> To: Chris Plummer; Shafi Ahmad; hotspot-dev at openjdk.java.net
> >>> Subject: Re: [8u] RFR for JDK-6515172: Runtime.availableProcessors()
> >>> ignores Linux taskset command
> >>>
> >>> On 16/09/2016 4:17 AM, Chris Plummer wrote:
> >>>> You should probably include the backport of JDK-8165153 since it
> >>>> was introduced by JDK-6515172.
> >>> This is a simplified backport of 6515172 suitable for Java 8. It
> >>> does end up being a combination of that fix and 8165153, but you
> >>> can't be a backport of two bugs, and there are no distinct parts
> >>> that might map to each bug. That was why originally this was flagged
> >>> under a separate bug id. But I agreed that this could be considered
> >>> a simpified backport of
> >> 6515172.
> >>> Thanks,
> >>> David
> >>>
> >>>> cheers,
> >>>>
> >>>> Chris
> >>>>
> >>>> On 9/15/16 2:51 AM, David Holmes wrote:
> >>>>> Looks good. Reviewed.
> >>>>>
> >>>>> Thanks,
> >>>>> David
> >>>>>
> >>>>> On 15/09/2016 4:40 PM, Shafi Ahmad wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> Please review the backport [modified] of bug: "JDK-6515172
> >>>>>> Runtime.availableProcessors() ignores Linux taskset command" to
> >> jdk8u.
> >>>>>> Please note that the backport is not clean and we can't do as it is.
> >>>>>> Please note
> >>>>>> 1. The changes are made by 'Andreas Eriksson' who left Oracle.
> >>>>>> 2. There is difference in logging mechanism in jdk9 and jdk8
> >>>>>> is different and file logTag.hpp doesn't exists in jdk8.
> >>>>>> 3. Newly added test pass after this change. It fails without
> >>>>>> this change.
> >>>>>>
> >>>>>> Webrev link:
> >>> http://cr.openjdk.java.net/~shshahma/8154324/webrev.02/
> >>>>>> Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-6515172
> >>>>>> Original patch pushed to jdk9:
> >>>>>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/c5480d4abfe4
> >>>>>>
> >>>>>> Testing: jprt and running jtreg.
> >>>>>>
> >>>>>> Regards,
> >>>>>> Shafi
> >>>>>>
>
More information about the hotspot-dev
mailing list