RFR(XXS) : 8166483 : gtest fmw should be updated to support null detection on SS >= 12u4

[David Holmes]

On 22/09/2016 5:24 PM, igor.ignatyev at oracle.com wrote:
> David,
>
> As you mentioned, we use SS12u4 now, and I doubt we will use earlier
> releases of SS in JDK 9 and beyond. Hence I don't think it will be an
> issue for us.
>
> I can consider it as Reviewed by you, right?

Yes.

Thanks,
David

> -- II
>
> ----- Reply message -----
> From: "David Holmes" <david.holmes at oracle.com>
> To: "Igor Ignatyev" <igor.ignatyev at oracle.com>
> Cc: "hotspot-dev at openjdk.java.net Developers" <hotspot-dev at openjdk.java.net>
> Subject: RFR(XXS) : 8166483 : gtest fmw should be updated to support
> null detection on SS >= 12u4
> Date: Thu, Sep 22, 2016 08:53
>
> On 22/09/2016 2:57 PM, Igor Ignatyev wrote:
>> Hi David,
>>
>>> To be clear we are expecting/requiring to always build with SS12u4 or later to allow this fix to enable changes to the test logic - right?
>>
>> right. null detection is still disabled for SS12u3 or before, so we will get a compile-time error like 'The operation "const long == MyClass*" is illegal.’ trying to compile 'ASSERT_EQ(NULL, myPointer)’.
>
> Ok. Given we do compile with SS12u4 this seems okay then.
>
> Thanks,
> David
>
>> — Igor
>>
>>> On Sep 22, 2016, at 3:59 AM, David Holmes <david.holmes at oracle.com> wrote:
>>>
>>> Hi Igor,
>>>
>>> On 22/09/2016 7:43 AM, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev/8166483/webrev.00/
>>>>> 3 lines changed: 1 ins; 0 del; 2 mod;
>>>>
>>>> Hi all,
>>>>
>>>> could you please review this tiny fix which enables null detection functionality in gtest on solaris if it’s been build by Solaris Studio >= 12.4? Due to disabled null detection, we have to explicitly cast NULL to a type of an actual value, i.e. instead of nice and clear 'ASSERT_EQ(NULL, myPointer)’ we have to write ‘ASSERT_EQ((MyClass*) NULL, myPointer)’. Reviewing 8165433[1], we came to the conclusion that ASSERT_EQ(NULL, myPointer) is what we really want. W/O this patch, the latest version of 8165433[2] fails during build on solaris.
>>>
>>> To be clear we are expecting/requiring to always build with SS12u4 or later to allow this fix to enable changes to the test logic - right?
>>>
>>> Thanks,
>>> David
>>>
>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8166483
>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8166483/webrev.00/
>>>> testing: I’ve run jprt w/ 8165433 integrated
>>>>
>>>> [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-September/020982.html
>>>> [2] http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8165433/webrev.03/
>>>>
>>>> Thanks,
>>>> — Igor
>>>>
>>
>