RFR(S) : 8178695: jdk.test.lib.artifacts.ArtifactContainer has to be public

Igor Ignatyev igor.ignatyev at oracle.com
Thu Apr 13 01:45:54 UTC 2017


Hi George, Christian,

thank you for your reviews!
-- Igor

> On Apr 12, 2017, at 5:40 PM, Christian Tornqvist <christian.tornqvist at oracle.com> wrote:
> 
> Hi Igor,
> 
> This looks good, thanks for fixing this :)
> 
> Thanks,
> Christian
> 
>> On Apr 12, 2017, at 8:15 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> http://cr.openjdk.java.net/~iignatyev//8178695/webrev.00/index.html
>>> 38 lines changed: 33 ins; 5 del; 0 mod; 
>> 
>> Hi all,
>> 
>> could you please review this small fix for the testlibrary?
>> 
>> @ArtifactContainer is created to support repeating @Artifact annotations, but it is package private class, which causes a compilation error if one uses more than one @Artifact. the fix make j.t.l.a.ArtifactContainer publicly accessible.
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev//8178695/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8178695
>> 
>> Thanks,
>> -- Igor
>> 
>> 
> 



More information about the hotspot-dev mailing list