RFR(XL/M) : 8178788: wrap JCStress test suite as jtreg tests

[Igor Ignatyev]

Hi Felix,

I understand your point and use-case and believe it is important and useful, however I don't think we should do that now. 1st of all, current jcstress wrapper is able to run precompiled tests from jsctress-tests-all, so if people write their own jcstress based tests, they will still need to use jcstress to build and run them. 2nd, hotspot/test/applications/jcstress tests depend on the version of jcstress, and currently the version is defined in wrapper, so I'd prefer to have the wrapper as much closer to these tests as possible. that is to say, if we have high need for running custom jcstress tests, then we should invest more in jcstress driver/wrapper (and maybe infra) so it will be possible to have tests in jcstress format as part of our test bases, but this is out of scope of this RFE.

Thanks,
-- Igor

> On Apr 18, 2017, at 11:39 PM, Frank Yuan <frank.yuan at oracle.com> wrote:
> 
> Hi Igor
>  
> The artifact which I talked about is the wrapper(JcstressRunner.java), I supposed there would be more people to create their tests with jcstress facility if the wrapper is put to a common place, there have been e.g. failure_handler, lib in hg.openjdk.java.net/jdk10/hs/test <http://hg.openjdk.java.net/jdk10/hs/test>.
>  
> If we put the wrapper into hotspot repo, even after JEP 296, it would be under test/hotspot/…
>  
> Certainly, it’s up to youJ
>  
>  
> Thanks
> Frank
>  
> From: Igor Ignatyev [mailto:igor.ignatyev at oracle.com] 
> Sent: Wednesday, April 19, 2017 1:47 PM
> To: Frank Yuan
> Cc: HotSpot Open Source Developers
> Subject: Re: RFR(XL/M) : 8178788: wrap JCStress test suite as jtreg tests
>  
> Hi Felix,
>  
> currently, <root>/test is not a jtreg testbase and it is not supported by make and the rest of infra, therefore it's not possible to have tests there. I don't want to mix up this fix w/ infra/make related work, and would prefer to think about this movement after (or as a part of) JEP 296 Consolidate the JDK Forest into a Single Repository.
>  
> actually, corelibs people are more than welcome to run hotspot/test, we (hotspot team) run jdk/test quite often and would really love to see other people running our tests before pushing changes which can affect hotspot and/or its tests. 
>  
> -- Igor
>  
>  
>> On Apr 18, 2017, at 8:32 PM, Frank Yuan <frank.yuan at oracle.com <mailto:frank.yuan at oracle.com>> wrote:
>>  
>> Hi Igor
>>  
>> This is really a valuable work!
>>  
>> Would you like to pull your artifacts up to the common repo hg.openjdk.java.net/jdk10/hs/test? <http://hg.openjdk.java.net/jdk10/hs/test?> That more people(e.g. corelibs J) can benefit from this.
>>  
>> Thanks
>> Frank
>>  
>>  
>> Subject: 
>> RFR(XL/M) : 8178788: wrap JCStress test suite as jtreg tests
>> Date: 
>> Tue, 18 Apr 2017 15:12:48 -0700
>> From: 
>> Igor Ignatyev <igor.ignatyev at oracle.com> <mailto:igor.ignatyev at oracle.com>
>> To: 
>> hotspot-compiler-dev at openjdk.java.net <mailto:hotspot-compiler-dev at openjdk.java.net> compiler <hotspot-compiler-dev at openjdk.java.net> <mailto:hotspot-compiler-dev at openjdk.java.net>, HotSpot Open Source Developers <hotspot-dev at openjdk.java.net> <mailto:hotspot-dev at openjdk.java.net>
>>  
>> 
>> http://cr.openjdk.java.net/~iignatyev//8178788/webrev.00/index.html <http://cr.openjdk.java.net/~iignatyev/8178788/webrev.00/index.html>
>> > 69903 lines changed: 69903 ins; 0 del; 0 mod; 
>> (69524 lines are generated)
>>  
>> Hi all,
>>  
>> could you please review this patch which adds a jtreg test wrapper for jcstress test suite and jtreg tests which run jsctress tests thru this wrapper?
>>  
>> webrev: http://cr.openjdk.java.net/~iignatyev//8178788/webrev.00/index.html <http://cr.openjdk.java.net/~iignatyev/8178788/webrev.00/index.html>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8178788 <https://bugs.openjdk.java.net/browse/JDK-8178788>
>> testing: applications/jcstress
>>  
>> Thanks,
>> -- Igor