RFR: 8179181: Cleanup BitMap search API

Kim Barrett kim.barrett at oracle.com
Sun Apr 23 04:49:08 UTC 2017


> On Apr 22, 2017, at 10:47 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Kim,
> 
> On 23/04/2017 3:03 AM, Kim Barrett wrote:
>> Please review this small simplification of the BitMap search API. The
>> change consists of dropping the _inline suffix from some function
>> names, and removing the now redundant (and also declared inline)
>> forwarding wrappers.
> 
> That was one seriously confused API! Presumably the intent was to have inlined and non-lined variants, but as you note everything was inline anyway. :(

I particularly liked the "Non-inline versionsof the above.” comment, and yet, there they are in the .inline.hpp…

> Cleanup looks good.

Thanks.

> 
> Thanks,
> David
> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8179181
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8179181/hotspot.00/
>> 
>> Testing:
>> JPRT




More information about the hotspot-dev mailing list