RFR (M) 8169061: Drop os::is_MP checks from Atomics
David Holmes
david.holmes at oracle.com
Wed Apr 26 06:42:55 UTC 2017
Looks fine to me!
Thanks,
David
-----
On 26/04/2017 4:36 PM, Aleksey Shipilev wrote:
> On 04/26/2017 05:29 AM, David Holmes wrote:
>> One oversight in atomic_bsd_x86.hpp:
>>
>> 118 inline void Atomic::inc_ptr(volatile intptr_t* dest) {
>> 119 __asm__ __volatile__ ( "lock addq $1,(%0)"
>> 120 :
>> 121 : "r" (dest), "r" (mp)
>>
>> Forgot to delete "mp" reference.
>>
>> Also copyright years need updating.
>
> Right, thanks for running it!
>
> I think I captured everything in here:
> http://cr.openjdk.java.net/~shade/8169061/webrev.02/
>
> Thanks,
> -Aleksey
>
More information about the hotspot-dev
mailing list