[8u] RFR for JDK-8168914: Crash in ClassLoaderData/JNIHandleBlock::oops_do during concurrent marking? to jdk8u-dev

[David Holmes]

Looks good!

Thanks,
David

On 26/04/2017 5:43 PM, Shafi Ahmad wrote:
> Hi David,
>
> Thank you for the review comment.
>
> I have deleted the redundant code from the cpp and hpp file under #ifdef ASSERT ... #endif
> Please find updated webrev - http://cr.openjdk.java.net/~shshahma/8168914/webrev.01/
>
> Regards,
> Shafi
>
>> -----Original Message-----
>> From: David Holmes
>> Sent: Wednesday, April 26, 2017 12:09 PM
>> To: Shafi Ahmad <shafi.s.ahmad at oracle.com>; hotspot-
>> dev at openjdk.java.net
>> Cc: Coleen Phillimore <coleen.phillimore at oracle.com>; Thomas Schatzl
>> <thomas.schatzl at oracle.com>; Stefan Karlsson
>> <stefan.karlsson at oracle.com>
>> Subject: Re: [8u] RFR for JDK-8168914: Crash in
>> ClassLoaderData/JNIHandleBlock::oops_do during concurrent marking? to
>> jdk8u-dev
>>
>> Hi Shafi,
>>
>> On 26/04/2017 3:32 PM, Shafi Ahmad wrote:
>>> Hi,
>>>
>>> Please review the backport of bug: "JDK-8168914: Crash in
>>> ClassLoaderData/JNIHandleBlock::oops_do during concurrent marking" to
>>> jdk8u-dev
>>>
>>> Please note that this is not a clean backport due to -
>>> A) Method  remove_handle(jobject h) is not present in jdk8u and looks it is
>> related to module so I haven't merged associated change to jdk8u.
>>
>> Without remove_handle_unsafe there is no use of "contains" so all of the
>> code in the block:
>>
>>   138 #ifdef ASSERT
>>   139 class VerifyContainsOopClosure : public OopClosure {
>>   ...
>>   167 #endif
>>
>> is dead code and can be deleted.
>>
>> Otherwise the backported code looks okay to me.
>>
>> Thanks,
>> David
>> -----
>>
>>> B) File moduleEntry.cpp is not present in jdk8u repo, so I have ignore its
>> changes.
>>>
>>>
>>> Webrev: http://cr.openjdk.java.net/~shshahma/8168914/webrev.00/
>>> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8168914
>>> Original patch pushed to jdk9:
>>> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/606c35b6fac5
>>>
>>> Test:  Run jprt and jtreg is in progress.
>>>
>>> Regards,
>>> Shafi
>>>