[PATCH] c1_Canonicalizer.hpp method const
David Holmes
david.holmes at oracle.com
Wed Aug 2 11:54:03 UTC 2017
Hi Vasili,
On 28/07/2017 7:22 PM, Vasili Svirski wrote:
> Hi,
>
> It is my first patch in the attached file.
Attachments get stripped by the mail system, you need to include things
as an inline attachment.
> In my patch, I just make one class method const
>
> In c1_Canonicalizer.hpp
> - Compilation *compilation() { return
> _compilation; }
> + Compilation *compilation() const { return _compilation; }
>
> My steps are:
> - read StyleGuide
> - make the simple change
> - build all
> - run native tests by jtreg
>
> Could somebody review the patch and confirm that I right in my steps?
Your steps are okay, but this is far too small a patch to warrant the
overhead of processing it. This type of thing would be fixed if doing
other work in the area; or as a broader project to tackle code cleanliness.
Cheers,
David
> Best regards,
> Vasili
>
More information about the hotspot-dev
mailing list