[10] RFR (XS) 8185900: hotspot build failed with gcc version Red Hat 4.4.7-3

[coleen.phillimore at oracle.com]

On 8/7/17 5:59 PM, David Holmes wrote:
> On 8/08/2017 1:07 AM, coleen.phillimore at oracle.com wrote:
>>
>> This seems fine and I will sponsor this, any other reviewers?  I 
>> think it meets trival rules.
>
> Perhaps. But my concern is that when we make a change to suit an old 
> compiler how do we know it won't trigger some new warning in a new 
> compiler? We have patches going in to fix gcc 7 at one end, and now 
> patches for gcc 4.4.7 at the other, with everything in between. That 
> is why we set a minimum supported compiler version. My understanding 
> was that flags we use now won't work with such old compilers anyway.
>

This seems like a harmless change. If it gives compilation warnings 
during checkin and fails, then we won't check it in.

Thanks,
Coleen

> David
>
>> Coleen
>>
>>
>> On 8/7/17 9:04 AM, Andrew Haley wrote:
>>> On 07/08/17 13:33, David Holmes wrote:
>>>> We only recently set the minimum supported gcc version to 4.7 for 
>>>> JDK 10:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8184338
>>>> http://mail.openjdk.java.net/pipermail/build-dev/2017-July/019518.html
>>> Well, yeah, but the distros have their own needs.  I think we should
>>> take pit on them, where reasonable.
>>>
>>