[10] RFR(S): 8185969: PPC64: Improve VSR support to use up to 64 registers

[Lindenmaier, Goetz]

Hi Gustavo,

thanks for the new change and posting to the other lists :)

I appreciate the shorter function. I think you need to 
check for noreg and keep that unchanged, though.
Some copyrights are not updated to 2017.
Consider it reviewed if the new function is fixed.

I posted the webrev on the cr server:
http://cr.openjdk.java.net/~goetz/wr17/8185969-ppcAsm/webrev.01/
and added you as contributor.

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Gustavo Serra Scalet
> Sent: Freitag, 11. August 2017 15:55
> To: Doerr, Martin <martin.doerr at sap.com>
> Cc: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
> dev at openjdk.java.net>; hotspot-dev at openjdk.java.net
> Subject: RE: [10] RFR(S): 8185969: PPC64: Improve VSR support to use up to 64
> registers
> 
> It worked for me Martin. Please check the new webrev:
> https://gut.github.io/openjdk/webrev/JDK-8185969/webrev.01/
> 
> Thanks for the review.
> 
> > -----Original Message-----
> > From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> > bounces at openjdk.java.net] On Behalf Of Gustavo Serra Scalet
> > Sent: quinta-feira, 10 de agosto de 2017 14:21
> > To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
> > dev at openjdk.java.net>
> > Subject: FW: [10] RFR(S): 8185969: PPC64: Improve VSR support to use up
> > to 64 registers
> >
> > Hi Martin,
> >
> > Alright. I'll analyze that and update to a new webrev.
> >
> > Thanks
> >
> > -----Original Message-----
> > From: Doerr, Martin [mailto:martin.doerr at sap.com]
> > Sent: quarta-feira, 9 de agosto de 2017 09:58
> > To: Gustavo Serra Scalet <gustavo.scalet at eldorado.org.br>; ppc-aix-port-
> > dev at openjdk.java.net
> > Subject: RE: [10] RFR(S): 8185969: PPC64: Improve VSR support to use up
> > to 64 registers
> >
> > Hi Gustavo,
> >
> > seems like you're preparing new VSR code :-) Nice change, but please
> > update the copyright messages in the modified files.
> >
> > register_ppc.cpp
> > to_vsr(): I don't like large code for a trivial computation. I'd prefer
> > something like "return as_VectorSRegister(encoding() + 32)".
> >
> > I can sponsor this change.
> >
> > Thanks and best regards,
> > Martin
> >
> >
> > -----Original Message-----
> > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> > bounces at openjdk.java.net] On Behalf Of Gustavo Serra Scalet
> > Sent: Dienstag, 8. August 2017 22:19
> > To: ppc-aix-port-dev at openjdk.java.net
> > Subject: [10] RFR(S): 8185969: PPC64: Improve VSR support to use up to
> > 64 registers
> >
> > Hi,
> >
> > Could you please review this specific PPC64 change to hotspot? The aim
> > of these changes is to allow a more complete usage of VSR. I make use of
> > these interfaces on an instrinsic that I plan to send next but I decided
> > to separate this change and send it first.
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8185969
> > Webrev: https://gut.github.io/openjdk/webrev/JDK-8185969/webrev/
> >
> > Best regards,
> > Gustavo Serra Scalet