RFR: 8186166: Generalize Atomic::cmpxchg with templates

Kim Barrett kim.barrett at oracle.com
Thu Aug 17 17:35:36 UTC 2017


> On Aug 17, 2017, at 8:45 AM, John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de> wrote:
> 
> On 08/16/2017 08:03 AM, Kim Barrett wrote:
>> New webrevs:
>> full: http://cr.openjdk.java.net/~kbarrett/8186166/hotspot.01/
>> incr: http://cr.openjdk.java.net/~kbarrett/8186166/hotspot.01.inc/
> 
> This fails to build on linux-sparc:
> 
> /var/lib/buildd/openjdk/hs/hotspot/src/os_cpu/linux_sparc/vm/atomic_linux_sparc.hpp:130:10: error: template-id ‘operator()<>’ for ‘T Atomic::PlatformCmpxchg<4>::operator()(T, volatile T*, T, cmpxchg_memory_order)’ does not match any template declaration
> inline T Atomic::PlatformCmpxchg<4>::operator()(T exchange_value,
>          ^~~~~~
> 
> Full log in [1]. Going to test linux-zero next.

I accidentally left off the “const” qualifier for those definitions for all of linux_sparc, linux_zero, and bsd_zero.
Sorry about that.  I’ve rechecked that bit for all platforms.

New webrevs:
full: http://cr.openjdk.java.net/~kbarrett/8186166/hotspot.02/
incr: http://cr.openjdk.java.net/~kbarrett/8186166/hotspot.02.inc/

> 
> Adrian
> 
>> [1] https://people.debian.org/~glaubitz/linux-sparc-build.log
> 
> -- 
> .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz at debian.org
> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913




More information about the hotspot-dev mailing list