RFR: 8186166: Generalize Atomic::cmpxchg with templates

[David Holmes]

Adrian,

FYI the linux-sparc port has somewhat fallen by the wayside so you may 
find numerous issues on that platform.

David

On 18/08/2017 7:41 AM, John Paul Adrian Glaubitz wrote:
> On 08/17/2017 11:32 PM, John Paul Adrian Glaubitz wrote:
>> On linux-sparc, the build currently fails with:
>>
>> Building target 'default (exploded-image)' in configuration 'linux-sparcv9-normal-server-release'
>> Compiling 2901 files for java.base
>> /var/lib/buildd/openjdk/hs/hotspot/src/os_cpu/linux_sparc/vm/vm_version_linux_sparc.cpp:65:5: error: prototype for ‘int VM_Version::platform_features(int)’ does
>> not match any in class ‘VM_Version’
>>   int VM_Version::platform_features(int features) {
>>       ^~~~~~~~~~
>> In file included from /var/lib/buildd/openjdk/hs/hotspot/src/os_cpu/linux_sparc/vm/vm_version_linux_sparc.cpp:28:0:
>> /var/lib/buildd/openjdk/hs/hotspot/src/cpu/sparc/vm/vm_version_sparc.hpp:196:15: error: candidate is: static void VM_Version::platform_features()
>>     static void platform_features();
>>                 ^~~~~~~~~~~~~~~~~
>> /var/lib/buildd/openjdk/hs/hotspot/src/os_cpu/linux_sparc/vm/vm_version_linux_sparc.cpp:61:13: warning: ‘bool detect_blkinit()’ defined but not used
>> [-Wunused-function]
>>   static bool detect_blkinit() {
>>               ^~~~~~~~~~~~~~
>> /var/lib/buildd/openjdk/hs/hotspot/src/os_cpu/linux_sparc/vm/vm_version_linux_sparc.cpp:57:13: warning: ‘bool detect_M_family()’ defined but not used
>> [-Wunused-function]
>>   static bool detect_M_family() {
>>               ^~~~~~~~~~~~~~~
>> /var/lib/buildd/openjdk/hs/hotspot/src/os_cpu/linux_sparc/vm/vm_version_linux_sparc.cpp:53:13: warning: ‘bool detect_niagara()’ defined but not used
>> [-Wunused-function]
>>   static bool detect_niagara() {
>>               ^~~~~~~~~~~~~~
>> lib/CompileJvm.gmk:208: recipe for target
>> '/var/lib/buildd/openjdk/hs/build/linux-sparcv9-normal-server-release/hotspot/variant-server/libjvm/objs/vm_version_linux_sparc.o' failed
>> make[3]: *** [/var/lib/buildd/openjdk/hs/build/linux-sparcv9-normal-server-release/hotspot/variant-server/libjvm/objs/vm_version_linux_sparc.o] Error 1
>> make[3]: *** Waiting for unfinished jobs....
>>
>> But I'm too tired now to debug this.
> 
> Ok, it seems that this is just a matter of fixing the declaration for
> 
> 	VM_Version::platform_features()
> 
> in hotspot/src/cpu/sparc/vm/vm_version_sparc.hpp.
> 
> Will send a patch tomorrow once I have verified that this is all that's
> needed to fix the build :).
> 
> Adrian
>