RFR 8173715 (rev2): Remove Flat Profiler

David Holmes david.holmes at oracle.com
Tue Aug 22 01:07:31 UTC 2017


Hi Gerard,

Sorry for the delay getting back to this.

On 19/08/2017 7:00 AM, Gerard Ziemski wrote:
> hi all,
> 
> The FlatProfiler (i.e. -Xprof) has been deprecated in jdk9, and now it’s the time to remove the code and obsolete the -Xprof flag.
> 
> Changes from rev1 to address David’s feedback:
> 
> - obsoleted the flag (it’s still accepted, but ignored)

Ok.

> - fixed copyright year in "src/os_cpu/linux_s390/vm/thread_linux_s390.hpp”

Ok.

> - improved comment about the signal based suspend/resume mechanism in "os_*.cpp” files

Not sure we should be referring to JFR here. The other comments I can 
live with. :)

> - removed entire comment from "src/os/solaris/vm/osThread_solaris.hpp"

Thanks.

> issue:  https://bugs.openjdk.java.net/browse/JDK-8173715
> webrev: http://cr.openjdk.java.net/~gziemski/8173715_rev2_hotspot

Looks okay. Just clarify the JFR comment situation.

Thanks,
David
-----



More information about the hotspot-dev mailing list