[RFH]: 8186443: Missing stdint.h for zero builds
David Holmes
david.holmes at oracle.com
Tue Aug 22 12:51:32 UTC 2017
On 22/08/2017 10:42 PM, John Paul Adrian Glaubitz wrote:
> Hi David!
>
> On 08/22/2017 02:40 PM, David Holmes wrote:
>> The patch in the webrev was not the committed changeset,
>> but I created the changeset from it.
>
> I'm not sure I understand what you mean?
Your patch:
http://cr.openjdk.java.net/~glaubitz/8186443/webrev.01/hotspot.patch
is just a basic patch, containing only the diff for the two files. Yet
your webrev shows e.g.:
rev 13458 : 8186443: Missing stdint.h for zero builds
Reviewed-by: kbarrett, dholmes
which is the details of the commit message. If I do a commit and then
generate the webrev the patch file is the actual changeset in a format
that can be directly imported by "hg import" including the user
identity, the bug attribution and reviewers. That's the format I get
from others.
Cheers,
David
>> Currently pushing through JPRT.
>
> Thanks.
>
More information about the hotspot-dev
mailing list