[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

Thomas Stüfe thomas.stuefe at gmail.com
Thu Aug 24 09:44:20 UTC 2017


Hi,

1) removed include seems fine.

2) Are we sure you do not need the special memset_with_concurrent_readers()
on Sparc Zero? The issues described at the beginning of
memset_with_concurrent_readers_sparc.cpp were important enough to justify
an own memset for sparc. Used in several places in the GC. Do the gtests
(especially test_memset_with_concurrent_readers.cpp) run through with your
patch?

Cheers, Thomas


On Thu, Aug 24, 2017 at 9:12 AM, John Paul Adrian Glaubitz <
glaubitz at physik.fu-berlin.de> wrote:

> Hello!
>
> On 08/23/2017 02:38 PM, David Holmes wrote:
> > These changes seem fine to me. I will sponsor this for you
> > once we have a second reviewer.
>
> Anyone willing to step up as the second reviewer?
>
> Thanks,
> Adrian
>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz at debian.org
> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>


More information about the hotspot-dev mailing list