Name clashes - was: Re: [RFR]: 8186723: Add SuperH as new architecture for linux
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Thu Aug 24 11:21:45 UTC 2017
On 08/24/2017 12:28 PM, Thomas Stüfe wrote:
> > On Thu, Aug 24, 2017 at 12:05 PM, John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de <mailto:glaubitz at physik.fu-berlin.de>> wrote:
> > > On 08/24/2017 11:57 AM, Thomas Stüfe wrote:
>
> Ah, I see it. "sh" was introduced by you in JDK-8186313 in platform.m4 (VAR_CPU).
> I just wondered why this macro was so shortish and whether we would risk potential
> name clashes with other macros.
>
> I wanted to discuss this in a separate issue.
>
> Sure.
Ok, so let's continue here as I'm not sure whether this issue should be addressed
before merging the above changeset. In my opinion, it's generally rather suboptimal
approach to use any global defines without surrounding underscores. But I am currently
undecided what would be the best approach to resolve this problem.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz at debian.org
`. `' Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the hotspot-dev
mailing list