Name clashes - was: Re: [RFR]: 8186723: Add SuperH as new architecture for linux

[David Holmes]

On 24/08/2017 9:21 PM, John Paul Adrian Glaubitz wrote:
> On 08/24/2017 12:28 PM, Thomas Stüfe wrote:
>> > On Thu, Aug 24, 2017 at 12:05 PM, John Paul Adrian Glaubitz 
>> <glaubitz at physik.fu-berlin.de <mailto:glaubitz at physik.fu-berlin.de>> 
>> wrote:
>> > > On 08/24/2017 11:57 AM, Thomas Stüfe wrote:
>>
>>         Ah, I see it. "sh" was introduced by you in JDK-8186313 in 
>> platform.m4 (VAR_CPU).
>>         I just wondered why this macro was so shortish and whether we 
>> would risk potential
>>         name clashes with other macros.
>>
>>     I wanted to discuss this in a separate issue.
>>
>> Sure.
> 
> Ok, so let's continue here as I'm not sure whether this issue should be 
> addressed
> before merging the above changeset.  In my opinion, it's generally 
> rather suboptimal
> approach to use any global defines without surrounding underscores. But 
> I am currently
> undecided what would be the best approach to resolve this problem.

Sorry I don't have any context here. What is the issue? And is it a 
hotspot issue or a build issue?

Thanks,
David

> Adrian
>