[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

[David Holmes]

On 25/08/2017 7:10 PM, John Paul Adrian Glaubitz wrote:
> On 08/24/2017 06:19 PM, Thomas Stüfe wrote:
>> Sorry, I should have been more specific. The gtests have nothing to do 
>> with the jtreg suite, they are a set of native tests using google test.
> 
> No problem. I'm still a relatively new to OpenJDK development, that's 
> why I need these heads-ups ;).
> 
>> Just execute (from your build directory):  
>> ./hotspot/variant-server/libjvm/gtest/gtestLauncher -jdk:./images/jdk
> 
> Ok, thanks!
> 
>> There is also a way to execute them from the make, but I do not know how.
> 
> "make check" doesn't work :(.
> 
> FWIW, I also talked to Oracle's toolchain guy for Linux SPARC and he 
> told me, the memset
> implementation in glibc has the same problem on Linux. So, your 
> reservations are actually
> justified and we should use the SPARC version of 
> memset_with_concurrent_readers on Zero
> on SPARC as well.
> 
> The problem is just how to make the code available outside the cpu/sparc 
> tree.

I would be looking at how to include 
./src/cpu/sparc/vm/memset_with_concurrent_readers_sparc.cpp in your 
build. Probably best to ask for help on build-dev - I'm no longer 
familiar with how that part of the build system operates. :(

David

> Adrian