8186476: Re: linux-sparc and linux-zero builds broken

[John Paul Adrian Glaubitz]

On 08/28/2017 10:19 PM, John Paul Adrian Glaubitz wrote:
> On 08/28/2017 10:12 PM, John Paul Adrian Glaubitz wrote:
>> On 08/28/2017 10:09 PM, Daniel D. Daugherty wrote:
>>> 8186734: AIX build broken after 8186166: Generalize Atomic::cmpxchg with templates
>>> Reviewed-by: goetz
>>>
>>> Same bug, different platform?
>>
>> Not quite. This regression came after 8186476, not 8186166.
> 
> FWIW, 8186476 most likely broke the PPC AIX build again, look at [1] and search
> for STATIC_CAST. It's been again used instead of STATIC_ASSERT.

Most likely, the whole patch needs to have s/STATIC_CAST/STATIC_ASSERT/g'.

Also, on Linux SPARC, the "template<>" is missing for Atomic::PlatformAdd<8>::add_and_fetch.

How shall we fix this? Shall I open bugs for every platform?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913