JDK10/RFR(M): 8182279: Add HW feature detection support for SPARC Core C5 (on Solaris).

[Patric Hedlin]

Hi David,

Thanks for making time to review.


On 08/29/2017 09:20 AM, David Holmes wrote:
> Hi Patric,
>
> On 29/08/2017 4:41 PM, Patric Hedlin wrote:
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8182279
>>
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8182279/
>
> I can't comment on the accuracy of the added features of course but 
> structurally etc these changes seem okay. Only odd thing I noticed in 
> vm_version_solaris_sparc.cpp:
>
>  410 #ifndef AV2_SPARC_SPARC6
>  411 #define AV2_SPARC_SPARC6     0x00000200 // REVB*, FPSLL*, 
> RDENTROPY, LDM* and STM*
>  412 #endif
>  413 #ifndef AV2_SPARC_DICTUNP
>  414 #define AV2_SPARC_DICTUNP    0x00002000 // Dictionary unpack 
> instruction
>
> why did you leave a gap in the sequence?
>
I have left out the support/definitions for Oracle Numbers:

#define AV2_SPARC_ONADDSUB    0x00000400 // Oracle Number add/subtract
#define AV2_SPARC_ONMUL       0x00000800 // Oracle Number multiply
#define AV2_SPARC_ONDIV       0x00001000 // Oracle Number divide

(Which I judged not very useful in the JVM.)

Best regards,
Patric

> Thanks,
> David
> -----
>
>> Note 1. SPARC Core C5 disclosure has been approved for reviewing on 
>> this list(s).
>> Note 2. SPARC Core C5 and M8 servers are currently not available to 
>> regular testing.
>> Note 3. Core C5 was previously named Core S5.
>>
>>
>> 8182279: Add HW feature detection support for SPARC Core C5 (on 
>> Solaris).
>>
>>      Updating SPARC feature/capability detection to include support 
>> for the SPARC Core C5.
>>
>>
>> Caveat:
>>
>>      This update will introduce some redundancies into the code base, 
>> features and definitions
>>      currently not used, addressed by subsequent bug or feature 
>> updates/patches. Fujitsu HW is
>>      treated very conservatively.
>>
>>
>> Testing:
>>
>>      Mostly tested on JDK9 (jtreg/RBT/hotspot/tier0-comp), RBT on 
>> non-M8 only.
>>      Testing on JDK10 (jtreg/RBT/hotspot/precheckin-comp), RBT on 
>> non-M8 only.
>>
>>
>> Best regards,
>> Patric