RFR(XXS) 8186797: cardtable_rs in g1CollectedHeap::initialize() defined, but never used

Zhengyu Gu zgu at redhat.com
Tue Aug 29 12:31:06 UTC 2017


Hi Erik,

Thanks for the review and sponsorship.


-Zhengyu


On 08/29/2017 05:04 AM, Erik Helin wrote:
> On 08/28/2017 01:50 PM, Zhengyu Gu wrote:
>> Please review this one line cleanup to remove unused cardtable_rs.
>>
>> It seems to be a leftover of refactoring 
>> G1RegionToSpaceMapper::create_mapper() to create_aux_memory_mapper().
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186797
>> Webrev: http://cr.openjdk.java.net/~zgu/8186797/webrev.00/
> 
> Looks good, Reviewed. I can sponsor this patch for you.
> 
> Thanks,
> Erik
> 
>> Test:
>>
>> hotspot_gc on Linux x64 with fastdebug and release build
>>
>>
>> Thanks,
>>
>> -Zhengyu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8186748.patch
Type: text/x-patch
Size: 1246 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/hotspot-dev/attachments/20170829/94b08308/8186748.patch>


More information about the hotspot-dev mailing list