8186476: Re: linux-sparc and linux-zero builds broken

[coleen.phillimore at oracle.com]

On 8/29/17 1:59 PM, Thomas Stüfe wrote:
>
> On Tue 29. Aug 2017 at 19:44, <coleen.phillimore at oracle.com 
> <mailto:coleen.phillimore at oracle.com>> wrote:
>
>
>
>     On 8/29/17 1:38 PM, Thomas Stüfe wrote:
>>     Hi Coleen,
>>
>>     On Tue, Aug 29, 2017 at 7:28 PM, <coleen.phillimore at oracle.com
>>     <mailto:coleen.phillimore at oracle.com>> wrote:
>>
>>
>>         This seems good to me.  I apologize that I asked for these
>>         asserts. I will sponsor.   Who are the reviewers?
>>
>>
>>     No need to, mistakes happen. I'm the sole reviewer for now.
>
>     Ok, I'll sponsor. Erik may be done for the day.
>     Coleen
>
>
> Thank you, Coleen!
>
> To be clear, I think the asserts are perfectly reasonable. It was just 
> a typo.

Yes, understood.  I thought they were a good idea.
Coleen

>
> Best regards, Thomas
>
>
>
>>
>>     ..Thomas
>>
>>         Coleen
>>
>>
>>         On 8/29/17 1:17 PM, Thomas Stüfe wrote:
>>
>>             Hi Adrian,
>>
>>             On Tue, Aug 29, 2017 at 6:39 PM, John Paul Adrian Glaubitz <
>>             glaubitz at physik.fu-berlin.de
>>             <mailto:glaubitz at physik.fu-berlin.de>> wrote:
>>
>>                 On 08/29/2017 01:45 PM, John Paul Adrian Glaubitz wrote:
>>
>>                     Ok, I will push a webrev this evening. I have
>>                     managed to fix the
>>                     Linux/s390
>>                     build now as well.
>>
>>                 Here's the first revision of my webrev [1].
>>
>>                 I verified:
>>
>>                 - linux-sparc
>>                 - linux-zero
>>                 - linux-s390
>>                 - linux-ppc
>>
>>                 I did not verify:
>>
>>                 - aix-ppc
>>                 - bsd-zero
>>
>>                 I don't have any AIX system available, unfortunately,
>>                 and I haven't had
>>                 the time
>>                 yet to set up a BSD machine, but I will do that
>>                 within this week. I will
>>                 then
>>                 perform test builds on bsd-x86 and bsd-zero and
>>                 provide patches if
>>                 necessary.
>>
>>                 Adrian
>>
>>                 [1]
>>                 http://cr.openjdk.java.net/~glaubitz/8186855/webrev.00/
>>                 <http://cr.openjdk.java.net/%7Eglaubitz/8186855/webrev.00/>
>>
>>             Thanks for the fix!
>>
>>             AIX builds fine with the patch. I think the bsd zero
>>             fixes are fine too
>>             (I'd feel confident enough to push the fix without
>>             verifying bsd zero, but
>>             it is up to you).
>>
>>             As neither of us can push this, could someone from Oracle
>>             please review and
>>             push the fix? Thanks!
>>
>>             ..Thomas
>>
>>
>>                 --
>>                   .''`.  John Paul Adrian Glaubitz
>>                 : :' :  Debian Developer - glaubitz at debian.org
>>                 <mailto:glaubitz at debian.org>
>>                 `. `'   Freie Universitaet Berlin -
>>                 glaubitz at physik.fu-berlin.de
>>                 <mailto:glaubitz at physik.fu-berlin.de>
>>                    `-    GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37
>>                 F5B5 F913
>>
>>
>>
>