8186476: Re: linux-sparc and linux-zero builds broken

David Holmes david.holmes at oracle.com
Tue Aug 29 21:46:57 UTC 2017


I know this has been pushed but just a nit:

src/os_cpu/linux_s390/vm/atomic_linux_s390.hpp

inline D Atomic::PlatformAdd<4>::add_and_fetch(I inc, D volatile* dest) 
const {
inline D Atomic::PlatformAdd<8>::add_and_fetch(I inc, D volatile* dest) 
const {

On all the other platforms the first parameter is called add_value. So 
the fix here went in the "wrong direction".

David

On 30/08/2017 2:39 AM, John Paul Adrian Glaubitz wrote:
> On 08/29/2017 01:45 PM, John Paul Adrian Glaubitz wrote:
>> Ok, I will push a webrev this evening. I have managed to fix the 
>> Linux/s390
>> build now as well.
> Here's the first revision of my webrev [1].
> 
> I verified:
> 
> - linux-sparc
> - linux-zero
> - linux-s390
> - linux-ppc
> 
> I did not verify:
> 
> - aix-ppc
> - bsd-zero
> 
> I don't have any AIX system available, unfortunately, and I haven't had 
> the time
> yet to set up a BSD machine, but I will do that within this week. I will 
> then
> perform test builds on bsd-x86 and bsd-zero and provide patches if 
> necessary.
> 
> Adrian
> 
>> [1] http://cr.openjdk.java.net/~glaubitz/8186855/webrev.00/
> 


More information about the hotspot-dev mailing list