[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

[David Holmes]

On 30/08/2017 8:16 AM, John Paul Adrian Glaubitz wrote:
> Hi!
> 
> Here's my suggested change to fix the Zero build on linux-sparc.
> 
> The first part of the change removes the unnecessary include of
> vmreg_sparc.inline.hpp in src/share/vm/compiler/oopMap.cpp.
> 
> The second change moves 
> src/cpu/sparc/vm/memset_with_concurrent_readers_sparc.cpp
> into the generic location 
> src/share/vm/gc/shared/memset_with_concurrent_readers_sparc.cpp,
> so it is picked up both during the Server and Zero builds on linux-sparc.
> 
> In order to prevent 
> src/share/vm/gc/shared/memset_with_concurrent_readers_sparc.cpp
> from being built on non-SPARC targets - which would fail because of the 
> inline
> assembly - I have guarded the entire file's definitions with "#ifdef 
> SPARC #endif".
> 
> I know the last bit of this changeset might not be the most elegant one, 
> but
> it's the least intrusive I could come up with and it fully fixes the 
> Zero builds
> for me on linux-sparc.

Sorry but I don't support putting a sparc specific file in a shared 
location.

Did you look at including 
src/cpu/sparc/vm/memset_with_concurrent_readers_sparc.cpp in the set of 
sources used when building zero for sparc? I would ask on build-dev for 
the best way to deal with this. Unfortunately I don't know my way around 
the "new" hotspot build well enough to give specific directions.

Thanks,
David

> Thanks,
> Adrian
> 
>> [1] http://cr.openjdk.java.net/~glaubitz/8186578/webrev.00/
>