8186476: Re: linux-sparc and linux-zero builds broken

[Thomas Stüfe]

On Tue, Aug 29, 2017 at 11:52 PM, John Paul Adrian Glaubitz <
glaubitz at physik.fu-berlin.de> wrote:

> On 08/29/2017 11:46 PM, David Holmes wrote:
>
>> I know this has been pushed but just a nit:
>>
>> src/os_cpu/linux_s390/vm/atomic_linux_s390.hpp
>>
>> inline D Atomic::PlatformAdd<4>::add_and_fetch(I inc, D volatile* dest)
>> const {
>> inline D Atomic::PlatformAdd<8>::add_and_fetch(I inc, D volatile* dest)
>> const {
>>
>> On all the other platforms the first parameter is called add_value. So
>> the fix here went in the "wrong direction".
>>
> I actually wanted to comment on this, but I went to dinner after pushing
> the changeset
> up for web review. This part of the changeset actually came from Thomas
> and he renamed
> "add_value" back to "inc" in the signature. I was a bit hesitant about
> which approach
> to use myself because renaming "inc" to "add_value" in the inline assembly
> changed
> the line width of the changed lines so much that the formatting looked
> ugly. But, OTOH,
> as you explained, this fix went into the wrong direction :(.
>
> Adrian
>
>
I do not think it matters much.
@David: Would you like us to open a follow up item to fix the variable name
on s390?

..Thomas


>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz at debian.org
> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>