RFR: Newer AMD 17h (EPYC) Processor family defaults

[David Holmes]

Hi Rohit,

On 31/08/2017 7:03 PM, Rohit Arul Raj wrote:
> Hello All,
> 
> I am Rohit Arul Raj, working at AMD India Pvt Ltd.
> 
> This is my first contribution to OpenJDK, so please guide me in case I
> have overlooked any process guidelines.
> I would like an volunteer to review this patch (openJDK9) which sets
> flag/ISA defaults for newer AMD 17h (EPYC) processor and help us with
> the commit process.
> 
> Webrev: https://www.dropbox.com/sh/08bsxaxupg8kbam/AADurTXLGIZ6C-tiIAi_Glyka?dl=0

Unfortunately patches can not be accepted from systems outside the 
OpenJDK infrastructure and ...

> I have also attached the patch (hg diff -g) for reference.

... unfortunately patches tend to get stripped by the mail servers. If 
the patch is small please include it inline. Otherwise you will need to 
find an OpenJDK Author who can host it for you on cr.openjdk.java.net.

> Note:
> 1) I have applied for Oracle Contributor Agreement on 30Aug2017.

Great! Welcome!

> 2) I have applied the changes on top of openJDK9/hotspot:

You will need to rebase to jdk10/hs/hotspot. JDK 9 is in the final 
stages of release.

>      changeset:   12823:b756e7a2ec33
>      tag:         tip
>      user:        prr
>      date:        Thu Aug 03 18:56:57 2017 +0000
>      summary:     Added tag jdk-9+181 for changeset 4a443796f6f5
> 
> 3) I have done regression testing using jtreg ($make default) and
> didnt find any regressions.

Sounds good, but until I see the patch it is hard to comment on testing 
requirements.

Thanks,
David
-----

>       There was 1 additional failure in the base run
> (java/util/ServiceLoader/ModulesTest.java), but was not able to
> reproduce it when I ran the test individually.
> 
>        Base Run:
>        ==========
>        Test results: passed: 4,749; failed: 5; error: 2
>         Report written to
> /home/rohit/project/submit/9dev-base/jdk/testoutput/jdk_core/JTreport/html/report.html
>         Results written to
> /home/rohit/project/submit/9dev-base/jdk/testoutput/jdk_core/JTwork
>         Error: Some tests failed or other problems occurred.
>         Summary: jdk_core
>         FAILED: java/io/BufferedInputStream/CloseStream.java
>         FAILED: java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java
>         FAILED: java/nio/channels/AsyncCloseAndInterrupt.java
>         FAILED: java/util/ServiceLoader/ModulesTest.java
>         FAILED: jdk/internal/reflect/constantPool/ConstantPoolTest.java
>         FAILED: sun/security/pkcs11/Secmod/AddTrustedCert.java
>         FAILED: sun/security/pkcs11/tls/TestKeyMaterial.java
>         TEST STATS: name=jdk_core  run=4756  pass=4749  fail=7
>         EXIT CODE: 3
>         EXIT CODE: 3
>          ../../test/TestCommon.gmk:398: recipe for target 'jtreg_tests' failed
>          make[2]: *** [jtreg_tests] Error 3
>          Makefile:43: recipe for target 'jdk_core' failed
>          make[1]: *** [jdk_core] Error 2
>          Makefile:77: recipe for target 'jdk_core' failed
>          make: *** [jdk_core] Error 2
> 
>          Patch Run:
>          =========
>         Test results: passed: 4,750; failed: 4; error: 2
>          Report written to
> /home/rohit/project/submit/9dev/jdk/testoutput/jdk_core/JTreport/html/report.html
>          Results written to
> /home/rohit/project/submit/9dev/jdk/testoutput/jdk_core/JTwork
>          Error: Some tests failed or other problems occurred.
>          Summary: jdk_core
>          FAILED: java/io/BufferedInputStream/CloseStream.java
>          FAILED:
> java/io/Serializable/unresolvableObjectStreamClass/UnresolvableObjectStreamClass.java
>          FAILED: java/nio/channels/AsyncCloseAndInterrupt.java
>          FAILED: jdk/internal/reflect/constantPool/ConstantPoolTest.java
>          FAILED: sun/security/pkcs11/Secmod/AddTrustedCert.java
>          FAILED: sun/security/pkcs11/tls/TestKeyMaterial.java
>          TEST STATS: name=jdk_core  run=4756  pass=4750  fail=6
>          EXIT CODE: 3
>          EXIT CODE: 3
>           ../../test/TestCommon.gmk:398: recipe for target 'jtreg_tests' failed
>           make[2]: *** [jtreg_tests] Error 3
>           Makefile:43: recipe for target 'jdk_core' failed
>           make[1]: *** [jdk_core] Error 2
>           Makefile:77: recipe for target 'jdk_core' failed
>           make: *** [jdk_core] Error 2
> 
>    Is there any further testing required?
> 
>    Please let me know your comments.
> 
> Thanks,
> Rohit
>