RFR: JDK-8190484 Move jvm.h, jmm.h et al to hotspot/*/include
David Holmes
david.holmes at oracle.com
Mon Dec 4 11:17:37 UTC 2017
Hi Magnus,
On 4/12/2017 9:06 PM, Magnus Ihse Bursie wrote:
> JDK-8190484 was created as a follow-up bug to the unification of the
> duplicated jvm.h, jvm_md.h and jmm.h, to determine the proper location
> of these files. This has now been decided to be hotspot/share/include
> and hotspot/os/$OS/include, respectively.
>
> This patch moves the relevant files there, but since this also frees up
> the src/$MODULE/native/include directories for the original purpose, it
> also unifies and simplifies the build logic for these directories, so
> that common code is executed for all modules to just copy any exported
> header files from these directories, should they exist.
>
> I'm intending to push this to jdk-hs.
Do you want this in 10 or 11? If you want 10 then you need to push to
jdk/jdk as there may not be another snapshot from jdk/hs.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190484
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8190484-move-hotspot-exported-includes/webrev.01
Seems okay for the jvm.h/jmm.h changes. I couldn't follow all the flow
on cleanups.
Thanks,
David
>
> /Magnus
More information about the hotspot-dev
mailing list