RFR: JDK-8190484 Move jvm.h, jmm.h et al to hotspot/*/include

mandy chung mandy.chung at oracle.com
Mon Dec 4 20:59:08 UTC 2017



On 12/4/17 12:40 PM, Magnus Ihse Bursie wrote:
> Technically, it's of course possible. But it does not fit very well 
> with the current DeclareRecipesForPhase. I agree with Erik, that for 
> now the reasonable approach is to have files that only include 
> CopyCommon. We can consider for future updates if it's worth 
> generalizing this.
>

Okay with me.   It'd be good if we can consider this in the future so 
that it avoids creating Copy-<module>.gmk for just the include header case.

> Updated webrev that restores the removed Copy-$MODULE.gmk files:
> http://cr.openjdk.java.net/~ihse/JDK-8190484-move-hotspot-exported-includes/webrev.02 
>
>

Looks good.
>
> Ok. I'll try to get it into jdk 10. Will push this to jdk/jdk as soon 
> as the needed fixes are integrated from jdk/hs.
>

Thank you.

Mandy



More information about the hotspot-dev mailing list