TLAB Refills for x86

Thomas Schatzl thomas.schatzl at oracle.com
Tue Dec 5 11:07:07 UTC 2017


Hi,

On Thu, 2017-11-30 at 13:09 -0800, JC Beyler wrote:
> Hi all,
> 
> The TLAB and the inline contiguous allocations handling are different
> for
> each architecture. On certain architectures, TLAB is never actually
> never
> refilled (ref:  https://bugs.openjdk.java.net/browse/JDK-8190862).
> 
> The idea behind the implementation for x86 is to separate TLAB usage
> to
> contiguous allocations in eden space.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191027
> WebRev: http://cr.openjdk.java.net/~rasbold/8191027/webrev.02/
> 
> Does anyone see any issues with this webrev?

I only see a slight issue with the new comment on how it works: the
first time I read it, it seemed to me that step 1+2 are inclusive, not
exclusive as is implemented (there is step 4 which explains that it is
exclusive retroactively). But maybe it's just me.

Looks good otherwise.

Thomas



More information about the hotspot-dev mailing list