TLAB Refills for x86

JC Beyler jcbeyler at google.com
Thu Dec 14 16:04:35 UTC 2017


Hi Thomas,

Done here:
http://cr.openjdk.java.net/~rasbold/8191027/webrev.04/

Let me know what you think,
Jc

On Mon, Dec 11, 2017 at 3:06 AM, Thomas Schatzl
<thomas.schatzl at oracle.com> wrote:
> Hi,
>
> On Thu, 2017-12-07 at 21:49 -0800, JC Beyler wrote:
>> Hi all,
>>
>> I added a reword of the comment (I could also remove it so let me
>> know):
>> http://cr.openjdk.java.net/~rasbold/8191027/webrev.03/
>>
>> Let me know if it is better!
>
>   my suggestion:
>
> 3872   // Allocate the instance:
> 3873   // 1) If TLAB is enabled:
> 3874   //  a) Try to allocate in the TLAB
> 3875   //  b) If fails, go to the slow path.
> 3876   //    Else If inline contiguous allocations are enabled:
> 3878   //  i) Try to allocate in eden
> 3879   //  ii) If fails due to heap end, go to slow path.
> 3880   // 2) If TLAB is enabled OR inline contiguous is enabled:
> 3881   //  a) Initialize the allocation
> 3882   //  b) Exit.
> 3883   // 3) Go to slow path.
> 3884
>
> Same idea for the SPARC change.
>
> Thanks,
>   Thomas
>


More information about the hotspot-dev mailing list