RFR: 8192123: Zero should use compiler built-ins for atomics on linux-arm

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Tue Dec 19 20:53:44 UTC 2017


Hi!

On 11/29/2017 03:08 PM, John Paul Adrian Glaubitz wrote:
> Like it has already been done for linux-m68k in JDK-8187227, Zero should also be
> patched on linux-arm to use compiler built-ins for the atomic functions in
> hotspot/os_cpu/linux_zero/assembler_linux_zero.cpp.

Since the development phase for OpenJDK 11 has started now, I would like
to ask for this change to be reviewed and hopefully approved again.

I have just successfully tested a rebased version of this patch on Debian
armel and it builds fine:

/usr/bin/printf  -- "----- Build times -------\nStart %s\nEnd   %s\n%s\n%s\n-------------------------\n" "`/bin/cat /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/make-support/build-times/build_time_start_TOTAL_human_readable`" "`/bin/cat /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/make-support/build-times/build_time_end_TOTAL_human_readable`" "`/bin/ls /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/make-support/build-times/build_time_diff_* | /bin/grep -v _TOTAL | /usr/bin/xargs /bin/cat | /usr/bin/sort -k 2`" "`/bin/cat /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/make-support/build-times/build_time_diff_TOTAL`" > >(/usr/bin/tee -a /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/build.log) 2> >(/usr/bin/tee -a /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/build.log >&2) && wait
----- Build times -------
Start 2017-12-19 11:02:55
End   2017-12-19 20:47:43

09:44:48 TOTAL
-------------------------
if test -f /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/make-support/exit-with-error ; then \
     exit 1 ; \
   fi
/usr/bin/printf "Finished building target 'images' in configuration 'linux-arm-normal-zero-release'\n" > >(/usr/bin/tee -a /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/build.log) 2> >(/usr/bin/tee -a /home/glaubitz/openjdk/hs/build/linux-arm-normal-zero-release/build.log >&2) && wait
Finished building target 'images' in configuration 'linux-arm-normal-zero-release'
make[1]: Leaving directory '/home/glaubitz/openjdk/hs'

Changeset can be found in [1].

Also, could maybe someone assist me in committing this change myself
as I am now officially a JDK committer :-).

Thanks,

Adrian

> [1] http://cr.openjdk.java.net/~glaubitz/8192123/webrev.00/

-- 
  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


More information about the hotspot-dev mailing list