RFR 8191985: Tlab refills for ARM

JC Beyler jcbeyler at google.com
Wed Dec 20 17:06:15 UTC 2017


Hi all,

Thanks for taking a look at the webrev!

Here is the change relative to jdk/hs:
http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/

Let me know what you think, hopefully I didn't make a mistake when
making the webrev :)
Jc


On Wed, Dec 20, 2017 at 5:50 AM, Daniel D. Daugherty
<daniel.daugherty at oracle.com> wrote:
> On 12/20/17 8:21 AM, Edward Nevill wrote:
>>
>> Hi Robin,
>>
>> I have eyeballed this, comparing it against the x86 version, and it looks
>> good to me.
>>
>> I'll try to build and test this, but it will probably be sometime between
>> Christmas and New Year.
>>
>> Just to confirm, the repo I should be patching and building is the
>> following?
>>
>> http://hg.openjdk.java.net/jdk/jdk
>
>
> The webrev shows this line:
>
>> Compare against:    http://hg.openjdk.java.net/jdk10/hs
>
> but that repo is stale with the creation of:
>
> http://hg.openjdk.java.net/jdk/jdk
>
> and
>
> http://hg.openjdk.java.net/jdk/hs
>
> I recommend HotSpot changes be made relative to
>
> http://hg.openjdk.java.net/jdk/hs
>
> Dan
>
>
>>
>> Thanks,
>> Ed.
>>
>> On Wed, 2017-12-20 at 08:58 +0100, Robbin Ehn wrote:
>>>
>>> Hi JC,
>>>
>>> Looks good to me.
>>>
>>> Can someone else please eyeball this?
>>>
>>> /Robbin
>>>
>> On 2017-12-20 05:39, JC Beyler wrote:
>>>
>>> Hi all,
>>>
>>> Thanks Robbin for the eye-balling.
>>>
>>> I did update the webrev to here:
>>> http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.01/
>>>
>>> Let me know what you think,
>>> Jc
>>>
>


More information about the hotspot-dev mailing list