TRACESPINNING in taskqueue.hpp

[yumin qi]

Thomas,

  I don't think it is a good the way to change #undef to #define to include
the tracing code since the #ifdef used in several files(in this case, turn
on TRACESPINNING in .hpp so it will be available in other .cpp or .hpp
files which include taskqueue.hpp) . We can change product.make to have

-DTRACESPINNING in gcc flag,  but the def  will be cancelled here.
  To have def in makefile turns on the definition everywhere in code but
changing #undef to #define in a file only change one file --- if multiple
files contains the def, they need changes too.

Thanks
Yumin


On Tue, Feb 14, 2017 at 10:45 AM, Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

> Hi Yumin,
>
> On Tue, 2017-02-14 at 08:43 -0800, yumin qi wrote:
> > Hi,
> >
> >   In file taskqueue.hpp, first #undef  TRACESPINNING
> >   The next whatever in #ifdef TRACESPINNING will not be included in
> > build.
> >
> >   Any comment?
>
>   not sure what you are asking here.
>
> Apparently anyone interested in using this code is supposed to change
> the #undef to #define. Similar to other performance debug code in
> hotspot.
>
> Thanks,
>   Thomas
>
>