(10) RFR (actually S) 8169881: Remove implicit Handle conversions oop->Handle

Kim Barrett kim.barrett at oracle.com
Wed Feb 15 01:18:15 UTC 2017


Not a review yet (though I will try), but saw this plus your question to me earlier today...

> On Feb 14, 2017, at 5:21 PM, coleen.phillimore at oracle.com wrote:
> And then there's the one in universe.cpp that's a naked oop, which can get moved before the call.
> 
>    // get the error object at the slot and set set it to NULL so that the
>    // array isn't keeping it alive anymore.
>    oop exc = preallocated_out_of_memory_errors()->obj_at(next);
>    assert(exc != NULL, "slot has been used already");
>    preallocated_out_of_memory_errors()->obj_at_put(next, NULL);     <= This on G1 can take out a lock for the oop_store and GC and move the default_err

I don’t think there’s a problem here.  Yes, it takes locks, but always without safepoint checks.




More information about the hotspot-dev mailing list