TRACESPINNING in taskqueue.hpp

[David Holmes]

Correction ...

On 15/02/2017 11:59 AM, David Holmes wrote:
> On 15/02/2017 4:45 AM, Thomas Schatzl wrote:
>> Hi Yumin,
>>
>> On Tue, 2017-02-14 at 08:43 -0800, yumin qi wrote:
>>> Hi,
>>>
>>>   In file taskqueue.hpp, first #undef  TRACESPINNING
>>>   The next whatever in #ifdef TRACESPINNING will not be included in
>>> build.
>>>
>>>   Any comment?
>>
>>   not sure what you are asking here.
>>
>> Apparently anyone interested in using this code is supposed to change
>> the #undef to #define. Similar to other performance debug code in
>> hotspot.

I misread the suggestion ... you may need to delete the undef not change 
it to a define. As Yumin notes this flag is used in multiple files and 
it isn't clear they all include this header.

David

> Right ... except there's really no reason to have the undef unless
> TRACESPINNING is normally set by the build - which it isn't. It would be
> marginally more developer friendly to just be able to add
> -DTRACESPINNING to the make args than having to edit the file first.
>
> Cheers,
> David
>
>> Thanks,
>>   Thomas
>>