jdk10 RFR for JDK-8167423: Incorrect implementation of JDK_Version::to_string OR proper return statement is missing OR proper comment is needed

[Shafi Ahmad]

Hi David,

Thank you for the review.

Regards,
Shafi

> -----Original Message-----
> From: David Holmes
> Sent: Wednesday, February 15, 2017 5:36 PM
> To: Shafi Ahmad <shafi.s.ahmad at oracle.com>; hotspot-
> dev at openjdk.java.net
> Subject: Re: jdk10 RFR for JDK-8167423: Incorrect implementation of
> JDK_Version::to_string OR proper return statement is missing OR proper
> comment is needed
> 
> Hi Shafi,
> 
> Looks good to me.
> 
> Thanks,
> David
> 
> On 15/02/2017 9:35 PM, Shafi Ahmad wrote:
> > Hi All,
> >
> > Summary: Adding return value check and update index variable.  It's a very
> small change to single file.
> >
> > Webrev link: http://cr.openjdk.java.net/~shshahma/8167423/webrev.00/
> > bug link: https://bugs.openjdk.java.net/browse/JDK-8167423
> >
> > Testing: jprt  and jtreg test.
> >
> > Regards,
> > Shafi
> >