jdk10 RFR for JDK-8167423: Incorrect implementation of JDK_Version::to_string OR proper return statement is missing OR proper comment is needed

Shafi Ahmad shafi.s.ahmad at oracle.com
Thu Feb 16 08:26:12 UTC 2017


Hi Coleen,

Thank you for the review.

Regards,
Shafi

> -----Original Message-----
> From: Coleen Phillimore
> Sent: Thursday, February 16, 2017 2:09 AM
> To: hotspot-dev at openjdk.java.net
> Subject: Re: jdk10 RFR for JDK-8167423: Incorrect implementation of
> JDK_Version::to_string OR proper return statement is missing OR proper
> comment is needed
> 
> Shafi,
> This looks good to me also.  Thank you for fixing this.
> Coleen
> 
> On 2/15/17 6:35 AM, Shafi Ahmad wrote:
> > Hi All,
> >
> > Summary: Adding return value check and update index variable.  It's a very
> small change to single file.
> >
> > Webrev link: http://cr.openjdk.java.net/~shshahma/8167423/webrev.00/
> > bug link: https://bugs.openjdk.java.net/browse/JDK-8167423
> >
> > Testing: jprt  and jtreg test.
> >
> > Regards,
> > Shafi
> 


More information about the hotspot-dev mailing list