RFR (XS) 8175269: [s390] cleanup calls to vtable_start_offset() and vtable_length_offset()

Schmidt, Lutz lutz.schmidt at sap.com
Tue Feb 21 19:31:42 UTC 2017


Hi Martin,

thank you for checking it out. 

Regards, Lutz


Dr. Lutz Schmidt | Reitenweg 11 | 69226 Nußloch

> On 21 Feb 2017, at 18:28, Doerr, Martin <martin.doerr at sap.com> wrote:
> 
> Hi Lutz,
> 
> this one looks good to me, too. The other platforms also use the Klass version.
> I can also sponsor this one as it only touches s390 files and targets jdk10, but have to wait for a jdk10 reviewer.
> 
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Schmidt, Lutz
> Sent: Dienstag, 21. Februar 2017 17:46
> To: hotspot-dev at openjdk.java.net
> Subject: RFR (XS) 8175269: [s390] cleanup calls to vtable_start_offset() and vtable_length_offset()
> 
> Hi all,
> 
> May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8175269
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175269/
> 
> Description:
> The two static functions are declared/defined in class Klass, but accessed via the subclass InstanceKlass. This is true for s390 only. All other architectures access them via the defining class. My change removes the “detour” via InstanceKlass.
> 
> Thanks,
> Lutz
> 



More information about the hotspot-dev mailing list