RFR: 8168914: Crash in ClassLoaderData/JNIHandleBlock::oops_do during concurrent marking

David Holmes david.holmes at oracle.com
Wed Feb 22 04:26:04 UTC 2017


On 22/02/2017 1:49 AM, Erik Helin wrote:
>
>
> On 02/21/2017 02:57 AM, Kim Barrett wrote:
>>> On Feb 20, 2017, at 5:52 PM, David Holmes <david.holmes at oracle.com>
>>> wrote:
>>>> 02 -> 03:
>>>> - Only use load_acquire when reading the size for the "head" chunk
>>>
>>> Sorry but I don't like the way this is done - the conditional may end
>>> up being more expensive than the unnecessary load-acquire. Unrolling
>>> the first loop iteration, as per the email discussion, is a better
>>> way to go IMO.
>>
>> +1
>
> David, Kim, please see new patches at:
> - inc: http://cr.openjdk.java.net/~ehelin/8168914/03-04/

Didn't need to add a new function to the API just to unroll the first 
loop iteration! :(

Ditto Kim's comments.

Thanks,
David
-----

> - full: http://cr.openjdk.java.net/~ehelin/8168914/04/
>
> Thanks,
> Erik


More information about the hotspot-dev mailing list