jdk10 RFR for JDK-8167423: Incorrect implementation of JDK_Version::to_string OR proper return statement is missing OR proper comment is needed

[David Holmes]

Hi Shafi,

On 23/02/2017 7:28 PM, Shafi Ahmad wrote:
> Hi Coleen, David,
>
> This is reviewed for jdk10 but when I sent for push to one of my colleague he has suggested me to push is jdk9 and this will automatically pushed to jdk10.
>
> So can this be pushed this to jdk9? If yes should I sent a separate review request or current review is sufficient?

No - this is a P4 bug and we are in RDP1 for JDK 9 so this can not be 
pushed to 9 unless it goes through a specific critical approval process.

David
-----

> Regards,
> Shafi
>
>> -----Original Message-----
>> From: Shafi Ahmad
>> Sent: Thursday, February 16, 2017 1:56 PM
>> To: Coleen Phillimore <coleen.phillimore at oracle.com>; hotspot-
>> dev at openjdk.java.net
>> Subject: RE: jdk10 RFR for JDK-8167423: Incorrect implementation of
>> JDK_Version::to_string OR proper return statement is missing OR proper
>> comment is needed
>>
>> Hi Coleen,
>>
>> Thank you for the review.
>>
>> Regards,
>> Shafi
>>
>>> -----Original Message-----
>>> From: Coleen Phillimore
>>> Sent: Thursday, February 16, 2017 2:09 AM
>>> To: hotspot-dev at openjdk.java.net
>>> Subject: Re: jdk10 RFR for JDK-8167423: Incorrect implementation of
>>> JDK_Version::to_string OR proper return statement is missing OR proper
>>> comment is needed
>>>
>>> Shafi,
>>> This looks good to me also.  Thank you for fixing this.
>>> Coleen
>>>
>>> On 2/15/17 6:35 AM, Shafi Ahmad wrote:
>>>> Hi All,
>>>>
>>>> Summary: Adding return value check and update index variable.  It's
>>>> a very
>>> small change to single file.
>>>>
>>>> Webrev link:
>> http://cr.openjdk.java.net/~shshahma/8167423/webrev.00/
>>>> bug link: https://bugs.openjdk.java.net/browse/JDK-8167423
>>>>
>>>> Testing: jprt  and jtreg test.
>>>>
>>>> Regards,
>>>> Shafi
>>>