RFR (S) 8144518: ClassVerboseTest crashes on Windows

[David Holmes]

On 18/01/2017 2:03 PM, Kim Barrett wrote:
>> On Jan 17, 2017, at 9:57 PM, David Holmes <david.holmes at oracle.com> wrote:
>>
>> Hi Coleen,
>>
>> On 18/01/2017 12:13 PM, Coleen Phillimore wrote:
>>>
>>>
>>> On 1/17/17 7:02 PM, David Holmes wrote:
>>>> Hi Coleen,
>>>>
>>>> The bug report does not explain the problem so it is unclear whether
>>>> this workaround is minimal. Also some commentary somewhere would be
>>>> useful else the bug might return inadvertently - more generally I'd
>>>> like to understand what other code might be impacted by this.
>>>
>>> Christian and I spent a solid week looking for the windows Visual Studio
>>> bug that caused this but weren't able to find it.  He verified that it's
>>> fixed in VS2015.  I think that's in the bug report.  The code generated
>>> is in the bug report with annotations of what lines the code it was
>>> executing and which instructions caused the truncation and sign
>>> extension leading to a negative offset from the start of _bcp.
>>
>> I'm not seeing that listing in the bug report. What code was generated versus what code should have been generated is precisely what I was looking for. And some idea of what problematic source code looks like.
>
> Some (most?) of the analysis and reproducer that Coleen is referring to are over in the duplicate
> https://bugs.openjdk.java.net/browse/JDK-8171968

Ah! Thanks Kim.

Coleen: all much clearer now. Reviewed.

Thanks,
David