RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

Mandy Chung mandy.chung at oracle.com
Fri Jan 27 16:26:56 UTC 2017


> On Jan 26, 2017, at 5:07 PM, Brent Christian <brent.christian at oracle.com> wrote:
> 
> Hi,
> 
> Please review my updated approach for fixing 8156073 ("2-slot
> LiveStackFrame locals (long and double) are incorrect") in the experimental portion of the StackWalker API, added in JDK 9.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8156073
> Webrev: http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/

3734     element->int_field_put(_mode_offset, value);

hotspot code uses 2-space indentation

stackwalk.hpp
  line 96 - extra line can be removed.

I agree with Remi to make the MODE_* constants in LiveStackFrameInfo final and PrimitiveSlot::size() public.

Thanks for the good test and I want to take another look at it and get back to you.

Mandy


More information about the hotspot-dev mailing list