RFR (S) 8183229: Implement WindowsSemaphore::trywait

Mikael Gerdin mikael.gerdin at oracle.com
Mon Jul 3 07:53:09 UTC 2017


Just realized I didn't send this to the list!
/m

On 2017-06-30 10:56, Mikael Gerdin wrote:
> Hi Kim
> 
> On 2017-06-30 02:01, Kim Barrett wrote:
>>> On Jun 29, 2017, at 8:50 AM, Mikael Gerdin <mikael.gerdin at oracle.com> 
>>> wrote:
>>>
>>> Hi all,
>>>
>>> To help with some upcoming patches I'd like to add the trywait 
>>> operation to the platform-independent Semaphore class. It's currently 
>>> lacking a Windows-implementation.
>>>
>>> Testing: JPRT testing on Windows platforms
>>> Webrev: http://cr.openjdk.java.net/~mgerdin/8183229/webrev.0/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8183229
>>>
>>> Thanks
>>> /Mikael
>>
>> Code looks good, but needs a test for the new function in 
>> hotspot/test/native/runtime/test_semaphore.cpp.
> 
> Oh! Of course!
> 
> How about:
> http://cr.openjdk.java.net/~mgerdin/8183229/webrev.0_to_1/
> http://cr.openjdk.java.net/~mgerdin/8183229/webrev.1/
> 
> I've run the unit test on all JRPT platforms.
> 
> /Mikael
> 
>>


More information about the hotspot-dev mailing list